-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add POI-less specification support #1638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 63 63
Lines 4128 4129 +1
Branches 566 566
=======================================
+ Hits 4047 4048 +1
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Daniel-Noel this might be interesting for you (and maybe the already merged #1636 even more so). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks!
Pull Request Description
See #1602 and #1636 (and of course #950).
A specification containing a measurement with
"poi": ""
should be treated as POI-less. Do not currently support"poi": null
at the moment, but this could be considered later if there is desire for it - however the choice of empty string is primarily to align with the XML schema.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: