-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Allow reporting of coverage on PRs from forks #1622
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 63 63
Lines 4048 4048
Branches 576 576
=======================================
Hits 3955 3955
Misses 54 54
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@kratsg I have the |
Co-authored-by: Giordon Stark <[email protected]>
In the interest of moving other PRs forward I'm going to merge this in as we now have the |
* Report coverage to Codecov without using a secret Codecov token - c.f. codecov/codecov-action#29 (comment) - Effectively reverts Codecov logic part of PR #1622 * Ensure codecov/codecov-action v2 used - Amends PR #1623
Description
Resolves #1559
On all events (with the exception on
schedule
events) triggered by maintainers on the main project upload coverage to Codecov using thesecrets.CODECOV_TOKEN
(which seems to be faster?). If the event comes from a fork, then rely on the fact that the token isn't required, and upload the Coverage results onpull_request
events.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: