feat: Sort _ChannelSummaryMixin.channel_nbins by keys to match channels order
#1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
commented
Aug 4, 2021
Comment on lines
+52
to
+53
| spec["channels"].append(spec["channels"][0].copy()) | ||
| spec["channels"][-1]["name"] = "a_make_first_in_sort_channel2" |
There was a problem hiding this comment.
@kratsg there is probably a more elegant way to do this, so please give recommendations and ask for changes here.
matthewfeickert
changed the title
_ChannelSummaryMixin.channel_nbins by keys to match channels order
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 63 63
Lines 4023 4024 +1
Branches 571 572 +1
=======================================
+ Hits 3929 3930 +1
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kratsg
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1545
This PR sorts the
_ChannelSummaryMixin.channel_nbinsdictby its keys such that its keys are in the same order as the entries of the_ChannelSummaryMixin.channelslist. This is done for aesthetics mostly and for quick checks, as users should rely ondictkeys notdictordering. It additionally adds a test.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: