Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Temporarily move to testing against SciPy pre-releases #1532

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jul 26, 2021

Description

As described in Issue #1531, the nightly tests against the HEAD of SciPy's source have been failing for so long that they are no longer useful and are generating too many false positives (test failures) for the HEAD of dependencies workflow to be a useful test. Until the build issue can be resolved, replace testing from HEAD against testing against releases with release candidates as eligible installs.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Temporarily remove installs of SciPy from the HEAD of source to reduce false failures in 'HEAD of dependencies' workflow
   - c.f. Issue #1531
* Use pip install --pre to test against release candidates of SciPy

@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Jul 26, 2021
@matthewfeickert matthewfeickert self-assigned this Jul 26, 2021
@matthewfeickert matthewfeickert changed the title tests: Temporarily move to testing against SciPy pre-releases test: Temporarily move to testing against SciPy pre-releases Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1532 (653c9cd) into master (025ffe9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1532   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          63       63           
  Lines        4006     4006           
  Branches      565      565           
=======================================
  Hits         3912     3912           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 25.51% <ø> (ø)
unittests 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025ffe9...653c9cd. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 3ff84b6 into master Jul 26, 2021
@matthewfeickert matthewfeickert deleted the fix/use-scipy-release-candidates branch July 26, 2021 02:52
matthewfeickert added a commit that referenced this pull request Jul 27, 2021
…esting (#1533)

* Use nightly wheels of SciPy from Anaconda's PyPI to avoid building SciPy from source for 'HEAD of dependencies' workflow
   - Huge thanks to Ralf Gommers (@rgommers) for pointing this out!
   - c.f. https://anaconda.org/scipy-wheels-nightly/scipy
* Effectively reverts PR #1532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant