Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pre-commit hooks versions and run order #1490

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 15, 2021

Description

Update pre-commit hooks and bump pyupgrade in the pre-commit hooks run order. As pre-commit hooks execute sequentially as defined in .pre-commit-config.yaml, those that can edit the code base like pyupgade should run before others like black that will apply formatting.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update and apply pre-commit hooks:
   - github.com/pre-commit/pre-commit-hooks: v3.4.0 → v4.0.1
   - github.com/asottile/pyupgrade: v2.15.0 → v2.19.4
   - github.com/psf/black: v21.5b1 → v21.6b0
   - github.com/nbQA-dev/nbQA: v0.8.0 → v0.12.0
* Move pyupgrade so that it runs sooner
   - pre-commit hooks execute in order of definition in .pre-commit-config.yaml, so hooks that can change the codebase should execute before linter hooks
* Remove quotes from time interval on pre-commit.ci autoupdate_schedule

@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Jun 15, 2021
@matthewfeickert matthewfeickert self-assigned this Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1490 (6124ea0) into master (5dc122a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1490   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          63       63           
  Lines        4006     4006           
  Branches      565      565           
=======================================
  Hits         3912     3912           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 25.51% <ø> (ø)
unittests 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/infer/calculators.py 100.00% <ø> (ø)
src/pyhf/interpolators/code4.py 95.23% <ø> (ø)
src/pyhf/parameters/paramview.py 94.73% <ø> (ø)
src/pyhf/workspace.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc122a...6124ea0. Read the comment docs.

@matthewfeickert matthewfeickert merged commit f5dad29 into master Jun 15, 2021
@matthewfeickert matthewfeickert deleted the chore/update-pre-commit-hooks branch June 15, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant