Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove load option from Docker workflow publish steps #1442

Merged
merged 3 commits into from
May 10, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 10, 2021

Description

Fix for PR #1441 in which load and push can not be used simultaneously for the docker/build-push-action@v2 action. So remove load as the image isn't needed locally.

Push the build result to a registry (--push)

Shorthand for --output=type=registry. Will automatically push the
build result to registry.

Load the single-platform build result to docker images (--load)

Shorthand for --output=type=docker. Will automatically load the
single-platform build result to docker images.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove load from docker/build-push-action@v2 action publish steps
   - load and push can not be used in the same step
   - load option: Shorthand for --output=type=docker
* Amends PR #1441

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions fix A bug fix Docker Involving Docker images or builds labels May 10, 2021
@matthewfeickert matthewfeickert self-assigned this May 10, 2021
@matthewfeickert matthewfeickert changed the title fix: Docker fix: Remove load from Docker workflow publish steps May 10, 2021
@matthewfeickert matthewfeickert changed the title fix: Remove load from Docker workflow publish steps fix: Remove load option from Docker workflow publish steps May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1442 (d4615c1) into master (5693d27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1442   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          63       63           
  Lines        3967     3967           
  Branches      555      555           
=======================================
  Hits         3873     3873           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 25.58% <ø> (ø)
unittests 97.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5693d27...d4615c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions Docker Involving Docker images or builds fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant