Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upload coverage to Codecov in flagged stages for complete coverage report #1380

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 26, 2021

Description

First noted in PR #1377, this allows for running the main tests, uploading the coverage to Codecov with a "unittests" flag, then running the tests for the contrib module, and uploading the new coverage report with these tests added to the main tests with a "contrib" flag.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Upload coverage reports to Codecov in staged runs with different flags to allow for iterative reporting
   - Allows for testing contrib module separately buy adding the coverage to the final report
   - c.f. https://docs.codecov.io/docs/flags

@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Mar 26, 2021
@matthewfeickert matthewfeickert self-assigned this Mar 26, 2021
@matthewfeickert
Copy link
Member Author

@lukasheinrich @kratsg This is a nice trick that we can probably use if we wanted finer coverage reporting in the future. 👍

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1380 (44c0d1b) into master (8a65295) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          63       63           
  Lines        3808     3808           
  Branches      538      538           
=======================================
  Hits         3714     3714           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 24.18% <ø> (?)
unittests 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a65295...44c0d1b. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 40f15e3 into master Mar 26, 2021
@matthewfeickert matthewfeickert deleted the ci/report-coverage-with-different-flags branch March 26, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant