Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in Using Calculator learn notebook #1331

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Feb 19, 2021

Pull Request Description

Thanks to @madbaron for the catch.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use the ToyCalculator API for computing the pvalues/expected pvalues in the 'Toy-Based' section
* Update returns to match v0.6.0 API of 0-d tensors

@kratsg kratsg added the docs Documentation related label Feb 19, 2021
@kratsg kratsg self-assigned this Feb 19, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1331 (d130080) into master (9ee94f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          63       63           
  Lines        3760     3760           
  Branches      538      538           
=======================================
  Hits         3666     3666           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
unittests 97.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee94f1...d130080. Read the comment docs.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much @kratsg and thank you very much for reporting @madbaron!

@matthewfeickert matthewfeickert merged commit bbb43f6 into master Feb 20, 2021
@matthewfeickert matthewfeickert deleted the fix/calculatorAPINB branch February 20, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants