Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Zenodo BibTeX author field in citation in docs #1323

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 17, 2021

Description

@matthewfeickert was too quick on the trigger for PR #1322 and forgot to get the docs too. Doh! :(

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update the BibTeX author field for the Zenodo archive citation in the docs
   - Amends PR #1322

@matthewfeickert matthewfeickert added the docs Documentation related label Feb 17, 2021
@matthewfeickert matthewfeickert self-assigned this Feb 17, 2021
@matthewfeickert
Copy link
Member Author

If you git grep the old pattern you still get

$ git grep "Heinrich, Lukas and Feickert, Matthew and Stark, Giordon"
docs/JOSS/paper.bib:  author = "{Heinrich, Lukas and Feickert, Matthew and Stark, Giordon}"

but the JOSS paper should be treated as frozen and so this is fine.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1323 (84c0cdf) into master (7f97073) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1323   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          63       63           
  Lines        3760     3760           
  Branches      538      538           
=======================================
  Hits         3666     3666           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
unittests 97.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f97073...84c0cdf. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 6c28066 into master Feb 17, 2021
@matthewfeickert matthewfeickert deleted the docs/change-citation-in-docs branch February 17, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants