Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update minimum required tqdm release to avoid repr crash #1302

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 9, 2021

Description

As tqdm/tqdm#624 which @kratsg opened up has been resolved, take advantage of its resolution by picking up the release in which is it fixed, v4.56.1, by requiring a minimum compatible version of tqdm of v4.56 in setup.cfg.

Example of it working now:

>>> import tqdm
>>> import sys
>>> print(tqdm.__version__, sys.version, sys.platform)
4.56.1 3.8.6 (default, Jan  5 2021, 00:14:15) 
[GCC 9.3.0] linux
>>> a = tqdm.tqdm([], disable=True)
>>> print(a)
0it [00:00, ?it/s]
>>> str(a)
'0it [00:00, ?it/s]'
>>> dir(a)
['__bool__', '__class__', '__del__', '__delattr__', '__dict__', '__dir__', '__doc__', '__enter__', '__eq__', '__exit__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__iter__', '__le__', '__len__', '__lt__', '__module__', '__ne__', '__new__', '__nonzero__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_comparable', '_decr_instances', '_get_free_pos', '_instances', '_lock', 'clear', 'close', 'disable', 'display', 'external_write_mode', 'format_dict', 'format_interval', 'format_meter', 'format_num', 'format_sizeof', 'get_lock', 'iterable', 'leave', 'monitor', 'monitor_interval', 'moveto', 'n', 'pandas', 'pos', 'refresh', 'reset', 'set_description', 'set_description_str', 'set_lock', 'set_postfix', 'set_postfix_str', 'status_printer', 'total', 'unpause', 'update', 'wrapattr', 'write']

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update tqdm to require tqdm v4.56 as minimum to get tqdm.__repr__() crash fix
   - c.f. https://github.com/tqdm/tqdm/issues/624
   - Fix was released in tqdm v4.5.6.1, but minimum of v4.56 will pick this up

@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Feb 9, 2021
@matthewfeickert matthewfeickert self-assigned this Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1302 (96f8380) into master (29410b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          63       63           
  Lines        3749     3749           
  Branches      535      535           
=======================================
  Hits         3655     3655           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
unittests 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29410b7...96f8380. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 9d56349 into master Feb 9, 2021
@matthewfeickert matthewfeickert deleted the build/update-tqdm branch February 9, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants