fix: Don't use exact assert for test_probability.py #1252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid the issues with floating point comparison out to 15 decimal places that started surfacing with the release of
jaxlib
v0.1.58
don't use exactassert
s for floating point comparison intest_probability.py
.atol=1e-12
was chosen as that is well beyond the floating point precision that should matter for comparion here, but not up to the1e-15
or so that caused the difference.Also remove redundant test added by mistake in PR #582
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: