Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate to new way to set environment variables in GHA #1139

Merged
merged 2 commits into from
Oct 20, 2020
Merged

chore: Migrate to new way to set environment variables in GHA #1139

merged 2 commits into from
Oct 20, 2020

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Oct 20, 2020 •
edited by matthewfeickert
Loading

Description

Resolves #1096.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Migrate workflow from deprecated 'set-env' and 'add-path' to 'exportVariable' and 'addPath'
   - c.f. https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

@kratsg kratsg added the chore Other changes that don't modify src or test files label Oct 20, 2020
@kratsg kratsg self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #1139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          62       62           
  Lines        3603     3603           
  Branches      521      521           
=======================================
  Hits         3500     3500           
  Misses         64       64           
  Partials       39       39
Flag Coverage Δ
#unittests 97.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038836b...7fe15ec. Read the comment docs.

@kratsg kratsg added the bumpversion/patch Create a patch version release label Oct 20, 2020
@github-actions
Copy link

I've queued this up. When it gets merged, I'll create a patch release from v0.5.2 → v0.5.3 which includes the following 43 change(s) [including this PR]:

  • chore: Migrate to new way to set environment variables in GHA
  • feat: Support ShapeFactor for import/export
  • style: Adopt new JAX style of np and jnp
  • docs: Add ss3L hepdata likelihood record
  • fix: Use JAX v0.2.4+ API
  • chore: Add file types for diff to .gitattributes
  • fix: Fixed parameter naming for compatibility with ROOT import/export
  • fix: Make workspaces immutable
  • fix: Logic bug for outer joins of merge channels
  • fix: Validate fit initialization parameters
  • fix: Use functools.wraps with events.register to render docstrings
  • docs: Use sphinx obj scope in docs by default
  • feat: Merge channel functionality in pyhf combine
  • ci: Make docs separate workflow
  • refactor: Migrate contrib download to contrib module
  • docs: Add importance of Issues to CONTRIBUTING.md
  • refactor: Rename paramset.fixed to paramset.suggested_fixed
  • feat: Add pyhf.workspace.build
  • fix: Import all infer submodules
  • docs: Use 1Lbb DOI in contrib download docstring
  • fix: Remove improper defaults for contrib download
  • docs: Add JSON example to README
  • docs: Add CodeMeta JSON-LD Context File
  • feat: Add API to download likelihood patchset archives
  • fix: Avoid deprecation warnings due to invalid escape sequences
  • docs: Add contributors to website
  • docs: Remove fixed parameters caveat for TRexFitter in babel
  • feat: Add test inversion / interval inference API
  • ci: Add code scanning CodeQL workflow
  • test: Ensure continuous approximation of Poisson implemented
  • chore: Migrate from bumpversion to bump2version
  • docs: Add citations from 2019 and 2020 papers
  • docs: Add information on announcement mailing list
  • ci: Add workflow for nightly tests of notebooks
  • ci: Add workflow dispatch support
  • chore: Update GitHub Action releases and Python runtimes in CI
  • ci: Add nightly tests using HEAD of dependencies
  • fix: Restrict iminuit to v1.4.X releases
  • chore: Migrate from pep517 to python-build
  • refactor: Remove unused fixtures, refactor validation tests
  • feat: Add fit to infer CLI API
  • feat: Add erf and erfinv to tensorlib
  • feat: Bump to modern pytest (6.0+)

    • If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

    @matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Oct 20, 2020
    @github-actions
    Copy link

    I've queued this up. When it gets merged, I'll create a patch release from v0.5.2 → v0.5.3 which includes the following 43 change(s) [including this PR]:

  • chore: Migrate to new way to set environment variables in GHA
  • feat: Support ShapeFactor for import/export
  • style: Adopt new JAX style of np and jnp
  • docs: Add ss3L hepdata likelihood record
  • fix: Use JAX v0.2.4+ API
  • chore: Add file types for diff to .gitattributes
  • fix: Fixed parameter naming for compatibility with ROOT import/export
  • fix: Make workspaces immutable
  • fix: Logic bug for outer joins of merge channels
  • fix: Validate fit initialization parameters
  • fix: Use functools.wraps with events.register to render docstrings
  • docs: Use sphinx obj scope in docs by default
  • feat: Merge channel functionality in pyhf combine
  • ci: Make docs separate workflow
  • refactor: Migrate contrib download to contrib module
  • docs: Add importance of Issues to CONTRIBUTING.md
  • refactor: Rename paramset.fixed to paramset.suggested_fixed
  • feat: Add pyhf.workspace.build
  • fix: Import all infer submodules
  • docs: Use 1Lbb DOI in contrib download docstring
  • fix: Remove improper defaults for contrib download
  • docs: Add JSON example to README
  • docs: Add CodeMeta JSON-LD Context File
  • feat: Add API to download likelihood patchset archives
  • fix: Avoid deprecation warnings due to invalid escape sequences
  • docs: Add contributors to website
  • docs: Remove fixed parameters caveat for TRexFitter in babel
  • feat: Add test inversion / interval inference API
  • ci: Add code scanning CodeQL workflow
  • test: Ensure continuous approximation of Poisson implemented
  • chore: Migrate from bumpversion to bump2version
  • docs: Add citations from 2019 and 2020 papers
  • docs: Add information on announcement mailing list
  • ci: Add workflow for nightly tests of notebooks
  • ci: Add workflow dispatch support
  • chore: Update GitHub Action releases and Python runtimes in CI
  • ci: Add nightly tests using HEAD of dependencies
  • fix: Restrict iminuit to v1.4.X releases
  • chore: Migrate from pep517 to python-build
  • refactor: Remove unused fixtures, refactor validation tests
  • feat: Add fit to infer CLI API
  • feat: Add erf and erfinv to tensorlib
  • feat: Bump to modern pytest (6.0+)

    • If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

    matthewfeickert
    matthewfeickert approved these changes Oct 20, 2020
    View reviewed changes
    Copy link
    Member

    @matthewfeickert matthewfeickert left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM @kratsg. Thanks!

    @kratsg kratsg requested a review from lukasheinrich October 20, 2020 20:10
    @kratsg kratsg merged commit 84381f8 into master Oct 20, 2020
    @kratsg kratsg deleted the chore/migrateToNewSetEnvGHA branch October 20, 2020 20:16
    kratsg pushed a commit that referenced this pull request Oct 20, 2020
    @actions-user
    Bump version: 0.5.2 → 0.5.3
    1e3f729 
    Triggered by #1139 via GitHub Actions.
    @matthewfeickert matthewfeickert mentioned this pull request Nov 1, 2020
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @matthewfeickert matthewfeickert matthewfeickert approved these changes

    @lukasheinrich lukasheinrich lukasheinrich approved these changes

    Assignees

    @kratsg kratsg

    Labels
    bumpversion/patch Create a patch version release chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Migrate workflows from deprecated 'set-env' and 'add-path' to 'exportVariable' and 'addPath'
    3 participants
    @kratsg @lukasheinrich @matthewfeickert