Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ShapeFactor for import/export #1136

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Oct 20, 2020

Description

Resolves #1080. This adds in the shapefactor import. ./cc @alexander-held

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add ShapeFactor support to pyhf.readxml
* Add ShapeFactor support to pyhf.writexml
* Add ShapeFactor test

@kratsg kratsg added the feat/enhancement New feature or request label Oct 20, 2020
@kratsg kratsg self-assigned this Oct 20, 2020
@lukasheinrich
Copy link
Contributor

we should add a validatiion test based on a xml config.
e.g. ./xmlimport_input/config/examples/example_DataDriven_controlRegion.xml

@kratsg
Copy link
Contributor Author

kratsg commented Oct 20, 2020

we should add a validatiion test based on a xml config.
e.g. ./xmlimport_input/config/examples/example_DataDriven_controlRegion.xml

I did: https://github.com/scikit-hep/pyhf/pull/1136/files#diff-2888ad0d96a0c85176d2918eb8a5d09dbebe4ea4724bb2497f5b4b9f70dc0536R328-R332

@lukasheinrich
Copy link
Contributor

ah missed that!

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1136 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   97.02%   97.14%   +0.11%     
==========================================
  Files          62       62              
  Lines        3598     3603       +5     
  Branches      519      521       +2     
==========================================
+ Hits         3491     3500       +9     
+ Misses         66       64       -2     
+ Partials       41       39       -2     
Flag Coverage Δ
#unittests 97.14% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/readxml.py 94.30% <100.00%> (+1.35%) ⬆️
src/pyhf/writexml.py 95.74% <100.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed1b51...6376cc4. Read the comment docs.

@kratsg kratsg force-pushed the feat/addShapeFactor branch from 4a0456b to 6376cc4 Compare October 20, 2020 19:00
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kratsg. LGTM.

@matthewfeickert matthewfeickert merged commit 038836b into master Oct 20, 2020
@matthewfeickert matthewfeickert deleted the feat/addShapeFactor branch October 20, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading ShapeFactors in xml workspace
3 participants