-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ShapeFactor for import/export #1136
Conversation
we should add a validatiion test based on a xml config. |
|
ah missed that! |
43054fc
to
4a0456b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
+ Coverage 97.02% 97.14% +0.11%
==========================================
Files 62 62
Lines 3598 3603 +5
Branches 519 521 +2
==========================================
+ Hits 3491 3500 +9
+ Misses 66 64 -2
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4a0456b
to
6376cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @kratsg. LGTM.
Description
Resolves #1080. This adds in the shapefactor import. ./cc @alexander-held
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: