Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove fixed parameters caveat for TRexFitter in babel #1093

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Oct 8, 2020

Description

Clean up docs a bit. This is supported as of #846 / #1051.

/cc @alexander-held

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove fixed parameters caveat for TRexFitter in babel as it is now supported

@kratsg kratsg added the docs Documentation related label Oct 8, 2020
@kratsg kratsg requested a review from matthewfeickert October 8, 2020 20:54
@kratsg kratsg self-assigned this Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1093   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          60       60           
  Lines        3507     3507           
  Branches      504      504           
=======================================
  Hits         3396     3396           
  Misses         68       68           
  Partials       43       43           
Flag Coverage Δ
#unittests 96.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf9daa...3594cfe. Read the comment docs.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kratsg just be careful when this gets squashed and merged as single commit PRs try to take on the content of just the commit.

@kratsg kratsg force-pushed the docs/fixUpCaveats branch from e128406 to 3133846 Compare October 8, 2020 21:12
@matthewfeickert
Copy link
Member

For the record, PRs with a net code removal are my favorite PRs. 🙂

@matthewfeickert matthewfeickert merged commit 3d121b3 into master Oct 8, 2020
@matthewfeickert matthewfeickert deleted the docs/fixUpCaveats branch October 8, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants