-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add JOSS paper #1089
docs: Add JOSS paper #1089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 63 63
Lines 3740 3740
Branches 531 531
=======================================
Hits 3646 3646
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
For further reference, here is the |
@lukasheinrich @kratsg Review and edits to the paper are welcome before I submit it. You can see it built here (but you have to build it each time you push): Paper compilation preview: https://whedon.theoj.org/
|
Note that there is the optional submission step of
which would be part of Issue #891. |
@lukasheinrich @kratsg As you both approved this I'm not going to merge this yet, but I will submit it to JOSS for approval. If we don't have any revisions then I'll merge it. |
@cranmer can you review this and give any thoughts and revision suggestions (c.f. above)? Also please check your ORCID to make sure I copied it right. |
@lukasheinrich @kratsg @cranmer Final thoughts and suggestions before submission? @lukasheinrich I think you had one or two comments? |
Submitted for review with Eloisa Bentivegna as the suggested topic editor. |
c600a6b
to
7282e4b
Compare
I changed the references as requested by @kthyng in openjournals/joss-reviews#2734. |
7282e4b
to
b230243
Compare
ba583ba
to
6c4ebd9
Compare
The paper is currently under review at openjournals/joss-reviews#2823 |
e18e6ef
to
e91ce43
Compare
e91ce43
to
8383b9d
Compare
6fd361a
to
963286b
Compare
* Reverts "Use inline citations as requested" commit c.f. https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html#citation_syntax > Citations go inside square brackets and are separated by semicolons
963286b
to
5debcc3
Compare
The paper has passed JOSS review! 🚀 Final requirements for publication include
This would most easily be achieved by merging this branch to @lukasheinrich @kratsg Are you both good with having the paper be part of the codebase? Or would you prefer that we have this branch stay orphaned and cut a specific GitHub / Zenodo release for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy for it to just be part of master
* Explicitly state the release of pyhf at time of writing JOSS paper is v0.5.4 - Link to pyhf v0.5.4 Zenodo archive * Amend PR #1089
Description
Resolves #502
Add the text and references for a JOSS paper submission. The paper is created following the Submitting a paper to JOSS guidelines.
N.B. This branch does not need to be merged to submit to JOSS. (Though it would probably be nice for posterity)
Action Item Checklist
Paper Checklist
Your paper should include:
Paper compilation preview: https://whedon.theoj.org/
https://github.com/scikit-hep/pyhf
docs/add-JOSS-paper
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: