Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add workflow for nightly tests of notebooks #1078

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 25, 2020

Description

Resolves #1077

To speed up the PR process, as the notebooks are the slowest tests by far, have the notebooks no longer be tested every PR but in a workflow that runs nightly on a CRON job and through workflow dispatch. This will ensure that any breaking changes that get through are caught within 24 hours, while speeding up CI. Workflow dispatch will also allow for the notebook tests to be run on any branch.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Migrate notebook tests from main CI to notebook testing workflow to speed up PRs
   - Run on as a nightly CRON job as well as through workflow dispatch
   - Don't run on pushes or PRs

@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Sep 25, 2020
@matthewfeickert matthewfeickert self-assigned this Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          59       59           
  Lines        3490     3490           
  Branches      499      499           
=======================================
  Hits         3379     3379           
  Misses         68       68           
  Partials       43       43           
Flag Coverage Δ
#unittests 96.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722750d...4ab4028. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 3a6bbf4 into master Sep 25, 2020
@matthewfeickert matthewfeickert deleted the ci/add-notebooks-workflow branch September 25, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate testing of notebooks into nightly test
2 participants