fix up notebooks

scikit-hep · Sep 4, 2020 · 4204b87 · 4204b87
1 parent 7693b84
commit 4204b87
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/docs/examples/notebooks/ImpactPlot.ipynb b/docs/examples/notebooks/ImpactPlot.ipynb
@@ -82,8 +82,17 @@
     "    _, model, data = make_model([\"CRtt_meff\"])\n",
     "\n",
     "    pyhf.set_backend(\"numpy\", pyhf.optimize.minuit_optimizer(verbose=True))\n",
+    "    \n",
+    "    constraints = constraints or []\n",
+    "    init_pars = model.config.suggested_init()\n",
+    "    fixed_params = model.config.suggested_fixed()\n",
+    "    \n",
+    "    for idx,fixed_val in constraints:\n",
+    "        init_pars[idx] = fixed_val\n",
+    "        fixed_params[idx] = True\n",
+    "    \n",
     "    result = pyhf.infer.mle.fit(\n",
-    "        data, model, fixed_vals=constraints, return_uncertainties=True\n",
+    "        data, model, init_pars=init_pars, fixed_params=fixed_params, return_uncertainties=True\n",
     "    )\n",
     "    bestfit = result[:, 0]\n",
     "    errors = result[:, 1]\n",

diff --git a/docs/examples/notebooks/pullplot.ipynb b/docs/examples/notebooks/pullplot.ipynb
@@ -72,8 +72,17 @@
     "    _, model, data = make_model([\"CRtt_meff\"])\n",
     "\n",
     "    pyhf.set_backend(\"numpy\", pyhf.optimize.minuit_optimizer(verbose=True))\n",
+    "    \n",
+    "    constraints = constraints or []\n",
+    "    init_pars = model.config.suggested_init()\n",
+    "    fixed_params = model.config.suggested_fixed()\n",
+    "    \n",
+    "    for idx,fixed_val in constraints:\n",
+    "        init_pars[idx] = fixed_val\n",
+    "        fixed_params[idx] = True\n",
+    "    \n",
     "    result = pyhf.infer.mle.fit(\n",
-    "        data, model, fixed_vals=constraints, return_uncertainties=True\n",
+    "        data, model, init_pars=init_pars, fixed_params=fixed_params, return_uncertainties=True\n",
     "    )\n",
     "    bestfit = result[:, 0]\n",
     "    errors = result[:, 1]\n",