Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steward updates different artifacts with same version number #1314

Closed
ignasi35 opened this issue Feb 11, 2020 · 5 comments · Fixed by #1946
Closed

Steward updates different artifacts with same version number #1314

ignasi35 opened this issue Feb 11, 2020 · 5 comments · Fixed by #1946
Labels
bug Something isn't working

Comments

@ignasi35
Copy link
Contributor

See https://github.com/playframework/play-ws/pull/461/files#diff-0:

Screenshot 2020-02-11 at 12 05 46

The steward was updating scalafmt from 2.0.1 to 2.0.7 and (incidentally) sbt-pgp got updated from 2.0.1 to 2.0.7 (which doesn't exist) too.
@mzuehlke
Copy link
Member

I'm pretty sure this is the same as:

@ignasi35 ignasi35 changed the title Steward updates different artificats with same version number Steward updates different artifacts with same version number Feb 11, 2020
@usommerl
Copy link

It looks like I have another instance of this issue here: https://github.com/usommerl/graalnative4s/pull/65/files

Update-odin-core-odin-slf4j-to-0-11-0-by-scala-steward-·-Pull-Request-65-·-usommerl-graalnative4s

@fthomas
Copy link
Member

fthomas commented Feb 19, 2021

Thanks for the report, @usommerl. That looks similar to the issue that was fixed with #1945. I think the problem was that Scala Steward found "odin" in "com.eed3si9n % sbt-buildinfo". We could make sure that is indeed fixed by that issue by adding another test case.

fthomas added a commit that referenced this issue Feb 19, 2021
@fthomas
Do not allow heuristics below 'moduleId' to modify ModuleIDs
221129d 
This only allows the `moduleId` heuristic to modify version numbers in
ModuleID definitions. It prevents that version numbers are bumped in
unrelated ModuleIDs.

Closes #1314.
@fthomas fthomas mentioned this issue Feb 19, 2021
Merged
@fthomas fthomas added the bug Something isn't working label Feb 20, 2021
@usommerl
Copy link

@fthomas I'm glad you could use it as a test case. Thanks for your work on scala-steward! I can't count how many hours it has saved me already. 👏

@fthomas
Copy link
Member

fthomas commented Feb 20, 2021

Thanks @usommerl, that's great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow heuristics below 'moduleId' to modify ModuleIDs scala-steward-org/scala-steward
4 participants
@fthomas @mzuehlke @ignasi35 @usommerl