Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Docker workflow to build-push-action v2 #29

Merged
merged 7 commits into from
May 19, 2021
Merged

ci: Update Docker workflow to build-push-action v2 #29

merged 7 commits into from
May 19, 2021

Conversation

matthewfeickert
Copy link
Member

c.f. scikit-hep/pyhf#1441 for reference

* Consolidate Docker testing and publishing workflow
   - Move out of CI workflow
   - Rename .github/workflows/publish-docker.yml -> .github/workflows/docker.yml
* Update Docker workflow to use docker/login-action@v2
   - Use update guide 
   - c.f. https://github.com/docker/build-push-action/blob/17822e4df435afa2aa88ec7d85b56ff55446ca36/UPGRADE.md
* Update Docker tagging system to be context dependent

@matthewfeickert matthewfeickert self-assigned this May 19, 2021
@matthewfeickert matthewfeickert merged commit cbce7a7 into main May 19, 2021
@matthewfeickert matthewfeickert deleted the ci/update-ci-to-v2 branch May 19, 2021 05:29
@matthewfeickert matthewfeickert mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert