Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEAKER: Offer to present #1

Open
tbashor opened this issue Jul 8, 2016 · 9 comments
Open

SPEAKER: Offer to present #1

tbashor opened this issue Jul 8, 2016 · 9 comments

Comments

@tbashor
Copy link
Contributor

tbashor commented Jul 8, 2016

Submit offer to present through typeform on main website

@tbashor
Copy link
Contributor Author

tbashor commented Aug 6, 2016

Submit offer to present through /api/proposal

Acceptance criteria:
-The following information is saved in the database
--Speaker record (name, email, github ID)
--Talk record (title, length, description)
--Proposal record (speaker ID, event/date, talk ID, status = new)

@dannynpham
Copy link
Collaborator

@tbasher Hey what is left on this ticket to do?

@tbashor
Copy link
Contributor Author

tbashor commented Aug 18, 2016

Writing tests for the api call. Unfortunately, I haven't been able to finish getting the testing set up. If you want to tackle writing the tests with supertest that would be great.

gabrielbonner added a commit that referenced this issue Aug 19, 2016
Results after playing around for a couple hours
@dannynpham
Copy link
Collaborator

So do you want me to install superset onto the app?

On Aug 18, 2016, at 10:51 AM, Todd Bashor [email protected] wrote:

Writing tests for the api call. Unfortunately, I haven't been able to finish getting the testing set up. If you want to tackle writing the tests with supertest that would be great.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #1 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AQvvN12qsV-rnsqEktPyqKa6vhrTXhS2ks5qhJuXgaJpZM4JHqpQ.

@tbasher
Copy link

tbasher commented Aug 19, 2016

Hello Danny. I was added to this thread by mistake. tbashor commented, not tbasher.

@tbashor
Copy link
Contributor Author

tbashor commented Aug 19, 2016

If you could integrate supertest into the app for api testing that would be great.

@dannynpham
Copy link
Collaborator

@tbashor Hey I got it setup I think, but I'm unable to push.

@dannynpham
Copy link
Collaborator

@tbashor also I don't think the test is working correctly can you check it for me? Thanks!

@tbashor
Copy link
Contributor Author

tbashor commented Aug 23, 2016

@dannynpham You should have a pending invite to this repo in your email. Accepting the invite should enable you to create the pull request. Once you create the pull request, I'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants