-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reconnecting websocket #1486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pcriadoperez
commented
Nov 30, 2024
•
edited
Loading
edited
- Remove CANCEL read_loop error log. This is not an error as the loop is closed before intentionally.
- Change log debug errors of errors to errors
- Fix error type for when message queue is full
- Return errors to user
- Add tests for ReconnectingWebsocket.py
- Fixes that if first connect fails it would not throw and let the user wait indefinetly
- Improves error handling passing to user error type for different scenarios
- Update docs
- Add websockets_proxy to requirements for python 3.8+
pcriadoperez
changed the title
fix: adjust logs in reconnecting websocket
fix: reconnecting websocket
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.