Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple and meaningful kube-state-metrics alert summary #394

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

michaelact
Copy link
Contributor

@samber
Copy link
Owner

samber commented Nov 27, 2023

Currently, in the template, the name field is used for writing both title and summary.

You must adapt name (without $labels.xxx variable) or description.

I think we will improve that in the future.

@michaelact
Copy link
Contributor Author

michaelact commented Dec 1, 2023

Hi! I've made a few adjustments to the code by adding a condition to skip writing a summary based on the name field. You can find the specific changes in dist/template.yml:14.

@samber
Copy link
Owner

samber commented Dec 1, 2023

cool, thanks for the contrib ;)

@samber samber merged commit 7fa11bf into samber:master Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants