fix(ssr): do not render class attribute when dynamic value is null, empty or undefined #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
commented
Nov 26, 2024
Comment on lines
-14
to
-17
| import { DEFAULT_SSR_MODE } from '@lwc/shared'; | ||
| import { DEFAULT_SSR_MODE, type CompilationMode } from '@lwc/shared'; | ||
| import { expectedFailures } from './utils/expected-failures'; | ||
| import type { FeatureFlagName } from '@lwc/features/dist/types'; | ||
| import type { CompilationMode } from '../index'; |
There was a problem hiding this comment.
Missed this in #4933
Comment on lines
-40
to
+50
| if (combinedScopeToken && attrName === 'class') { | ||
| attrValue += ' ' + combinedScopeToken; | ||
| hasClassAttribute = true; | ||
|
|
||
| if (attrName === 'class') { | ||
| if (attrValue === '') { | ||
| // If the class attribute is empty, we don't render it. | ||
| continue; | ||
| } | ||
|
|
||
| if (combinedScopeToken) { | ||
| attrValue += ' ' + combinedScopeToken; | ||
| hasClassAttribute = true; | ||
| } |
There was a problem hiding this comment.
I don't normally like to use continue, but some refactoring would be needed to avoid it here.
nolanlawson
approved these changes
Nov 26, 2024
|
/nucleus test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes two expected failures:
'attribute-class/unstyled/dynamic/index.js''attribute-class/with-scoped-styles-only-in-parent/dynamic/index.js'Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
The class attribute will not be rendered when the dynamic value is null, empty or undefined
GUS work item