fix: revert "fix(ssr): infer the SSR mode in renderComponent"
#4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d47c56c.
nolanlawson
changed the title
renderComponent (#4820)"renderComponent (#4820)"
nolanlawson
changed the title
renderComponent (#4820)"renderComponent"
wjhsf
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This reverts commit d47c56c (#4820).
It turns out we broke the Best tests with this PR (due to
node:utils/typesnot being Rollupified correctly), and plus it seems like it doesn't accurately detectasyncmode for some reason (it sometimes determinessync)?This PR was not super important so let's just revert it for now.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?