This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Download invoice for order #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
krzysztofwolski
approved these changes
Jul 2, 2020
dominik-zeglen
suggested changes
Jul 2, 2020
| {order.paymentStatusDisplay} / {order.statusDisplay} | ||
| </p> | ||
| </div> | ||
| {"invoices" in order && order.invoices?.length && ( |
There was a problem hiding this comment.
Suggested change
| {"invoices" in order && order.invoices?.length && ( | |
| {order?.invoices?.length > 0 && ( |
There was a problem hiding this comment.
Removing "invoices" in order causes error 
| @@ -17,13 +17,29 @@ const View: React.FC<RouteComponentProps<{ token?: string }>> = ({ | |||
| const { data: user } = useUserDetails(); | |||
| const guest = !user; | |||
|
|
|||
| const handleDownloadInvoice = () => { | |||
| if (order && "invoices" in order && order.invoices?.length) { | |||
There was a problem hiding this comment.
Suggested change
| if (order && "invoices" in order && order.invoices?.length) { | |
| if (order?.invoices?.length > 0) { |
| @@ -1,6 +1,6 @@ | |||
| import * as H from "history"; | |||
|
|
|||
| export interface IProps { | |||
| orders: any[]; | |||
| orders?: any[]; | |||
There was a problem hiding this comment.
It's temporary fix for crash when no order exists for a user, together with changes in src/@next/pages/OrdersHistory/OrdersHistory.tsx. We should create no order information view in the future if the appropriate design will exist.
orzechdev
force-pushed
the
feature/invoices
branch
from
d8479f8 to
e8d4cfb
Compare
AlicjaSzu
approved these changes
Jul 7, 2020
orzechdev
force-pushed
the
feature/invoices
branch
from
655f479 to
b7319ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adds the possibility to download invoice from the popup menu in the order details view for logged in user.
PR intended to be tested with API branch:
saleor/saleor#5732
PR intended to be tested with SDK branch:
saleor/saleor-sdk#13
Screenshots
Pull Request Checklist