feat: eip-1559 fixed gas prices #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Pull Request Test Coverage Report for Build 5927002806
💛 - Coveralls |
fmrsabino
suggested changes
Aug 16, 2023
src/chains/models.py
Outdated
Comment on lines
169
to
171
| exactly_one_variant = reduce( | ||
| xor, [fixed_wei_defined, fixed1559_defined, oracle_defined] | ||
| ) |
There was a problem hiding this comment.
This won't work as it is since True XOR True XOR True becomes False XOR True which becomes True and that won't match with "exactly one variant".
There was a problem hiding this comment.
Maybe something like:
exactly_one_variant = [fixed_wei_defined, fixed1559_defined, oracle_defined].count(True) == 1wdyt?
There was a problem hiding this comment.
Whoops I missed that one. Your suggestions sounds good. I will change it to that :)
fmrsabino
reviewed
Aug 17, 2023
src/chains/models.py
Outdated
Comment on lines
178
to
185
| "oracle_uri": "An oracle uri, fixed gas price or maxFeePerGas and maxPriorityFeePerGas should be \ | ||
| provided (but not multiple)", | ||
| "fixed_wei_value": "An oracle uri, fixed gas price or maxFeePerGas and maxPriorityFeePerGas \ | ||
| should be provided (but not multiple)", | ||
| "max_fee_per_gas": "An oracle uri, fixed gas price or maxFeePerGas and maxPriorityFeePerGas \ | ||
| should be provided (but not multiple)", | ||
| "max_priority_fee_per_gas": "An oracle uri, fixed gas price or maxFeePerGas and \ | ||
| maxPriorityFeePerGas should be provided (but not multiple)", |
There was a problem hiding this comment.
nitpick: the error detail can be extracted to a variable and referenced (seems to be the same for very field).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR resolves
Resolves #924
How it resolves it
GasPricemodel:maxFeePerGas(in Wei)maxPriorityFeePerGas(in Wei)