Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and upload arm64 images #796

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Build and upload arm64 images #796

merged 2 commits into from
Feb 17, 2023

Conversation

fmrsabino
Copy link
Contributor

  • In addition to linux/amd64 images, build and upload linux/arm64 images to DockerHub
  • Add QEMU step to support targeting multiple platforms in the build process

@fmrsabino
Build and upload arm64 images
f9c0718 
- In addition to `linux/amd64` images, build and upload `linux/arm64` images to DockerHub
- Add QEMU step to support targeting multiple platforms in the build process
@fmrsabino fmrsabino added github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code labels Feb 16, 2023
@fmrsabino fmrsabino self-assigned this Feb 16, 2023
@fmrsabino fmrsabino requested a review from a team as a code owner February 16, 2023 14:07
@fmrsabino fmrsabino requested review from Uxio0, moisses89, hectorgomezv and luarx and removed request for a team February 16, 2023 14:07
@coveralls
Copy link

coveralls commented Feb 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4202151809

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.788%
Totals Coverage Status
Change from base Build 4193449409: 0.0%
Covered Lines: 940
Relevant Lines: 942
💛 - Coveralls

@luarx
Copy link

luarx commented Feb 16, 2023

Btw @fmrsabino, do you think that is a good time to change the name of the Github action .github/workflow/test.yml?

@fmrsabino
Copy link
Contributor Author

Btw @fmrsabino, do you think that is a good time to change the name of the Github action .github/workflow/test.yml?

I can change it in a separate PR. It's just the name of the file. The actual pipeline has CI as its name. Maybe I can rename it to ci.yml?

@fmrsabino fmrsabino merged commit 1aa3323 into main Feb 17, 2023
@fmrsabino fmrsabino deleted the add-arm64-support branch February 17, 2023 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

@Uxio0 Uxio0 Uxio0 approved these changes

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx

Assignees

@fmrsabino fmrsabino

Labels
docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmrsabino @coveralls @luarx @Uxio0 @hectorgomezv