Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta ref_name to Feature serializers #764

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Add meta ref_name to Feature serializers #764

merged 3 commits into from
Jan 17, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 17, 2023

Fixes swagger not loading because of Serializer name conflict

@mmv08 mmv08 requested a review from a team as a code owner January 17, 2023 14:41
@mmv08 mmv08 requested review from fmrsabino, Uxio0 and moisses89 and removed request for a team January 17, 2023 14:41
@coveralls
Copy link

coveralls commented Jan 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3940637704

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.778%
Totals Coverage Status
Change from base Build 3937911729: 0.001%
Covered Lines: 898
Relevant Lines: 900
💛 - Coveralls

fmrsabino
fmrsabino suggested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions

src/chains/serializers.py Outdated Show resolved Hide resolved
src/safe_apps/serializers.py Outdated Show resolved Hide resolved
mmv08 and others added 2 commits January 17, 2023 16:16
@mmv08 @fmrsabino
Update src/chains/serializers.py
61a2583 
Co-authored-by: Frederico Sabino <[email protected]>
@mmv08 @fmrsabino
Update src/safe_apps/serializers.py
1fc5d5f 
Co-authored-by: Frederico Sabino <[email protected]>
fmrsabino
fmrsabino approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@mmv08 mmv08 merged commit b530ee0 into main Jan 17, 2023
@mmv08 mmv08 deleted the bug/swagger-conflict branch January 17, 2023 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @fmrsabino