Add default environment variables to docker-compose #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If no environment variables are not set (more specifically `NGINX_HOST_PORT`, `POSTGRES_PORT` and `DOCKER_NGINX_VOLUME_ROOT`) then docker-compose fails to start the containers - Even though the variables are set as an example in `.dev.env` which is read by `env_file`, those variables will only be available to the container and not to the docker-compose.yml file
Pull Request Test Coverage Report for Build 3647965811
💛 - Coveralls |
hectorgomezv
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
NGINX_HOST_PORT,POSTGRES_PORTandDOCKER_NGINX_VOLUME_ROOT) then docker-compose fails to start the containers.dev.envwhich is read byenv_file, those variables will only be available to the container and not to the docker-compose.yml file