Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beaconChainExplorerUriTemplate property #1241

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Sep 30, 2024

Summary

Resolves #1240

Due to restrictions of staking, we link to the Beacon Chain explorer to see the value of specific validators. At the moment, this is done via a client-side hardcoded value.

This adds a new beaconChainExplorerUriTemplate property, similar to blockExplorerUriTemplate. The reason for not adding the value directly is for extensibility as it is also possible to search for other values other than public keys, e.g. block number/hash, graffiti or state hash.

Changes

  • Add nullable beacon_chain_explorer_uri_public_key_template property.
  • Add relevant serializer and map property
  • Add mock value for tests.
  • Generate migration and add relevant test.

@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11102259998

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.501%

Totals Coverage Status
Change from base Build 10955950299: 0.005%
Covered Lines: 1197
Relevant Lines: 1203

💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review September 30, 2024 08:54
@iamacook iamacook requested a review from a team as a code owner September 30, 2024 08:54
@iamacook iamacook merged commit 790fdc9 into main Oct 2, 2024
17 checks passed
@iamacook iamacook deleted the beacon-chain-explorer branch October 2, 2024 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Beacon Chain explorer URLs to Chain
3 participants