Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL paths on CGW_URL #1183

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Allow URL paths on CGW_URL #1183

merged 1 commit into from
Jul 22, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

The function urljoin from urllib.parse expect a base and a url to concat.

As the path being concatenated to CGW_URL is /v1/hooks/events, the function urljoin interprets url as a base domain, and splits out any path it can have. This causes problems when the base URL does contain paths, as those are split out.

Changes

  • The URL being added to CGW_URL is now v1/hooks/events, and the / URL separator is concatenated to the base conditionally (to avoid separator duplications).

@hectorgomezv hectorgomezv self-assigned this Jul 22, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 22, 2024 09:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10038267628

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.661%

Totals Coverage Status
Change from base Build 9940688552: 0.0%
Covered Lines: 1176
Relevant Lines: 1180

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 5341f94 into main Jul 22, 2024
15 checks passed
@hectorgomezv hectorgomezv deleted the fix-cgw-url-building branch July 22, 2024 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants