Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function
urljoin
fromurllib.parse
expect abase
and aurl
to concat.As the path being concatenated to
CGW_URL
is/v1/hooks/events
, the functionurljoin
interpretsurl
as a base domain, and splits out any path it can have. This causes problems when the base URL does contain paths, as those are split out.Changes
CGW_URL
is nowv1/hooks/events
, and the/
URL separator is concatenated to thebase
conditionally (to avoid separator duplications).