Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the standard from 14 to 17 to avoid compile error #469

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

guanshaoheng
Copy link
Contributor

I am trying to implement the Graph network built based on torch_geometric to my cpp code by libtorch.

Thus the torchscatter lib file is needed by the GCNConv jit.

While using the old version to compile the c++ torch extension lib, I met following error.

miniconda3/lib/python3.11/site-packages/torch/include/c10/util/MaybeOwned.h:142:54: error: expected '(' for function-style cast or type construction
  142 |       std::is_nothrow_move_assignable_v<borrow_type> &&

After changing the CMAKE_CXX_STANDARD from 14 to 17, the error solved.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (140d3ad) to head (f69c797).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   97.23%   98.20%   +0.97%     
==========================================
  Files          10       10              
  Lines         217      223       +6     
==========================================
+ Hits          211      219       +8     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 7cabb53 into rusty1s:master Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants