Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Serde 1.0 #357

Closed
3 tasks done
cuviper opened this issue Dec 20, 2017 · 8 comments
Closed
3 tasks done

Update to Serde 1.0 #357

cuviper opened this issue Dec 20, 2017 · 8 comments

Comments

@cuviper
Copy link
Member

cuviper commented Dec 20, 2017

See #281, and this was previously in the next branch after #305.

@CAD97
Copy link
Contributor

CAD97 commented Apr 26, 2018

Now that rust-num/num-rational#9 is closed, do we have an estimated timeline for when we can expect to see a num v0.2.0 (pre)release with serde1 support?

At current, it is possible to monkey-patch together a num 0.2-git by adding a git dependency on the children of num, but it's not exactly pretty.

Scanning the num reexports, I spot the following issues marked with a 0.2 milestone:

@cuviper
Copy link
Member Author

cuviper commented Apr 27, 2018

Thanks for the summary -- there's really not much left! I don't have a schedule, but I'll try to wrap this up soon. Looking at your list:

  • num will need to clean up all its features to match the updated sub-crates.
  • num-bigint details: I already made the error type opaque, just want to remove big_digit::* from the public API.
  • num-complex no-std had a PR that stalled. I may just add the std feature with all functionality masked without it for now, then proper no-std support can come later.
  • BigInt assign ops don't have to be done for 0.2.0 either, but it would be nice.

@cuviper
Copy link
Member Author

cuviper commented Apr 27, 2018

num-complex no-std had a PR that stalled. I may just add the std feature with all functionality masked without it for now, then proper no-std support can come later.

Hmm, it's not that easy to defer, because some no-std features will need to switch to FloatCore, and we can't change that in the API later.

@CAD97
Copy link
Contributor

CAD97 commented Apr 27, 2018

Is there a reason Float doesn't have FloatCore as a "supertrait"? I realize that changing that would break semver-compatibility in num-traits, so is pretty much a non-option, but having that would allow relaxing Float bounds to FloatCore without breaking semver compatibility.

If you want to go the nuclear route for no_std future-proofing, in addition to config'ing everything out when opting out of the std feature, you could double every bound from Float to Float + FloatCore -- that way, removing one of the bounds would strictly be semver-compatible (though may break inference because inference is tricky).

In any case, I can help out some next week. The easy step is just to get the repository in 0.2.0-git mode, and that way those willing to use git dependencies at least don't have to recreate the facade to use the 0.2 previews.

@cuviper
Copy link
Member Author

cuviper commented Apr 27, 2018

Is there a reason Float doesn't have FloatCore as a "supertrait"? I realize that changing that would break semver-compatibility in num-traits, so is pretty much a non-option,

That's exactly the reason this wasn't done.

The easy step is just to get the repository in 0.2.0-git mode,

You mean for num itself, pointing to the existing 0.2.0-git of sub-crates? I actually did start that on my own branch here: https://github.com/cuviper/num/tree/release-0.2.0

@BelfordZ
Copy link

Any ETA on this? Trying to plan out some feature development around this.

@cuviper
Copy link
Member Author

cuviper commented Jun 26, 2018

Just need to finish release notes in #367, hopefully in the next day or so. If you want to kick the tires on that, it would be greatly appreciated!

@BelfordZ
Copy link

Thank you greatly @cuviper :) :)

bors bot added a commit that referenced this issue Jun 30, 2018
367: Release 0.2.0 r=cuviper a=cuviper

Closes #298.
Closes #357.
Closes #360.

Co-authored-by: Josh Stone <[email protected]>
Co-authored-by: Christopher Durham <[email protected]>
@bors bors bot closed this as completed in #367 Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants