-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize --color and --error-format options in rustdoc #53003
Stabilize --color and --error-format options in rustdoc #53003
Conversation
These flags were added in #49542 when rustdoc started emitting warnings for intra-doc links. The flags and parameters are the same as for rustc. These parameters are passed to any error emitter that rustdoc uses, so that errors from both rustc and rustdoc follow the same style. The defaults are A pending bugfix in Cargo (rust-lang/cargo#5862) will make it start capturing output from rustc/rustdoc, but to do so it needs to override their color settings so they don't accidentally strip color codes from their output due to being piped. I had personally forgotten that these flags were this recent and that they were unstable. Unless anyone else in @rust-lang/rustdoc objects, i'm merging this. @bors r+ |
📌 Commit dda85ab has been approved by |
…tions, r=QuietMisdreavus Stabilize --color and --error-format options in rustdoc Fixes rust-lang#52980 cc @kennytm r? @QuietMisdreavus
…tions, r=QuietMisdreavus Stabilize --color and --error-format options in rustdoc Fixes rust-lang#52980 cc @kennytm r? @QuietMisdreavus
As a supplement to the rationale of stabilization, passing
|
Rollup of 14 pull requests Successful merges: - #51919 (Provide `{to,from}_{ne,le,be}_bytes` functions on integers) - #52940 (Align 6-week cycle check with beta promotion instead of stable release.) - #52968 (App-lint-cability) - #52969 (rustbuild: fix local_rebuild) - #52995 (Remove unnecessary local in await! generator) - #52996 (RELEASES.md: fix the `hash_map::Entry::or_default` link) - #53001 (privacy: Fix an ICE in `path_is_private_type`) - #53003 (Stabilize --color and --error-format options in rustdoc) - #53022 (volatile operations docs: clarify that this does not help wrt. concurrency) - #53024 (Specify reentrancy gurantees of `Once::call_once`) - #53041 (Fix invalid code css rule) - #53047 (Make entire row of doc search results clickable) - #53050 (Make left column of rustdoc search results narrower) - #53062 (Remove redundant field names in structs)
Fixes #52980
cc @kennytm
r? @QuietMisdreavus