Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on trying to use revisions in run-make tests #131614

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Error on trying to use revisions in run-make tests #131614

merged 1 commit into from
Oct 13, 2024

Conversation

jieyouxu
Copy link
Member

Currently, run-make tests do not support revisions.

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 12, 2024
@jieyouxu jieyouxu mentioned this pull request Oct 12, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
@jieyouxu
Error on trying to use revisions in run-make tests
9f0f035 
Currently `run-make` tests do not support revisions.
@jieyouxu
Copy link
Member Author

Updated the unit test.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Oct 13, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2024

📌 Commit 9f0f035 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge of rust-lang#131645 - matthiaskrgr:rollup-lgr1ezu, r=matth…
2aa26d8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#131086 (Update unicode-width to 0.2.0)
 - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`)
 - rust-lang#131614 (Error on trying to use revisions in `run-make` tests)
 - rust-lang#131638 (compiletest: Move debugger setup code out of `lib.rs`)
 - rust-lang#131641 (switch unicode-data bitsets back to 'static')
 - rust-lang#131642 (Special case error message for a `build-fail` test that failed check build)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d5a133 into rust-lang:master Oct 13, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@rust-timer
Unrolled build for rust-lang#131614
a45a5e8 
Rollup merge of rust-lang#131614 - jieyouxu:rmake-no-rev, r=Kobzol

Error on trying to use revisions in `run-make` tests

Currently, `run-make` tests do not support revisions.
@jieyouxu jieyouxu deleted the rmake-no-rev branch October 13, 2024 14:26
@jieyouxu jieyouxu added the A-compiletest Area: The compiletest test runner label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jieyouxu @rustbot @rust-log-analyzer @Kobzol @bors