-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't disable codegen tests in PR CI #126173
Conversation
Seems like we should be using a different approach for skipping the codegen tests, something akin to a |
@Kobzol All codegen tests require LLVM, so the whole suite should get skipped for other backends. Though this already seems to be the case, given that this PR passes CI. Not sure why that condition was added in the first place, but it doesn't seem to be necessary anymore. (I don't think that other codegen backends run "normal" rustc tests at all -- right?) |
Thanks for fixing this! |
I would expect GCC/Cranelift to run at least a subset of the UI test suite, but I'm not sure. Anyway, since this seems to work, let's ship it, we ideally shouldn't skip these tests. r? @Kobzol @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6c4755d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
Fixes #126170.
r? @ghost