Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused cargo-platform dependency from tidy #123796

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Remove unused cargo-platform dependency from tidy #123796

merged 1 commit into from
Apr 12, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 11, 2024 •
edited
Loading

Noticed in #123788 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@bjorn3 bjorn3 mentioned this pull request Apr 11, 2024
Merged
@bjorn3 bjorn3 force-pushed the remove_cargo_platform branch from c92f5da to 55100e9 Compare April 11, 2024 16:44
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 12, 2024

📌 Commit 55100e9 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
@bors
Auto merge of rust-lang#123846 - matthiaskrgr:rollup-85y28av, r=matth…
bd71213 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#123796 (Remove unused cargo-platform dependency from tidy)
 - rust-lang#123830 (Remove `From` impls for unstable types that break inference)
 - rust-lang#123842 (fix typo in pin.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b467edd into rust-lang:master Apr 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
@rust-timer
Unrolled build for rust-lang#123796
46a0b4f 
Rollup merge of rust-lang#123796 - bjorn3:remove_cargo_platform, r=clubby789

Remove unused cargo-platform dependency from tidy

Noticed in rust-lang#123788 (comment)
@bjorn3 bjorn3 deleted the remove_cargo_platform branch April 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @clubby789 @bors @Mark-Simulacrum