show linker output even if the linker succeeds #119286

jyn514 · 2023-12-24T23:44:23Z

show stderr by default
show stdout if --verbose is passed
remove both from RUSTC_LOG
hide the linker cli args unless --verbose is passed

fixes #83436. fixes #38206. fixes #109979. helps with #46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134

try-job: aarch64-apple

r? @bjorn3

rustbot · 2023-12-24T23:44:33Z

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

jyn514 · 2023-12-24T23:53:38Z

hmm actually this is a slight expansion of scope but @bjorn3 how would you feel about not printing the giant list of linker arguments unless someone passes --verbose (#109979)

jyn514 · 2023-12-25T01:10:13Z

also i know we settled on not showing stdout by default but it's useful for debugging search paths - maybe we should show it after all? it seems silly to have to pass both -Wl,--verbose and --verbose. #46998 (comment)

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_interface/src/tests.rs

compiler/rustc_session/src/options.rs

compiler/rustc_codegen_ssa/src/back/link.rs

bors · 2024-01-06T18:43:05Z

☔ The latest upstream changes (presumably #119662) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2024-01-20T01:03:00Z

hmm. that test has the following comment:

rust/tests/incremental/commandline-args.rs

Lines 13 to 20 in e9a009f

    
           // Between revisions 1 and 2, we are changing the debuginfo-level, which should 
        
           // invalidate the cache. Between revisions 2 and 3, we are adding `--verbose` 
        
           // which should have no effect on the cache. Between revisions, we are adding 
        
           // `--remap-path-prefix` which should invalidate the cache: 
        
           //[rpass1] compile-flags: -C debuginfo=0 
        
           //[rpass2] compile-flags: -C debuginfo=2 
        
           //[rpass3] compile-flags: -C debuginfo=2 --verbose 
        
           //[rpass4] compile-flags: -C debuginfo=2 --verbose --remap-path-prefix=/home/bors/rust=src

i suppose those lines are all invalid now, it should be testing that the CGU is not reused? i'm not sure why it's testing --verbose specifically, maybe it's enough to test any untracked CLI arg. i'll change it to --diagnostic-width.

i'm realizing your comments are all about #119129. i feel slightly uncomfortable making unrelated changes in this PR ... how do you feel about splitting them into a separate PR so i can assign michaelwoerister?

bjorn3 · 2024-01-20T09:10:30Z

how do you feel about splitting them into a separate PR so i can assign michaelwoerister?

Sure

bjorn3 · 2024-01-20T20:42:54Z

hide the linker cli args unless --verbose is passed

I prefer not doing this. It is helpful whenever a linkage issue is opened to not have to ask to rerun with RUSTFLAGS="--verbose". If you revert this change r=me. If you still want to keep it, let me thing about it for a bit.

jyn514 · 2024-12-01T22:15:56Z

@rustbot ready

note that this is based off of #133633 so you may want to review that first.

bors · 2024-12-09T06:46:40Z

☔ The latest upstream changes (presumably #134052) made this pull request unmergeable. Please resolve the merge conflicts.

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3`

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? ``@bjorn3``

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? ```@bjorn3```

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? ````@bjorn3````

don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3` try-build: dist-x86_64-linux

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3` try-build: dist-x86_64-linux

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? ``@bjorn3`` try-build: dist-x86_64-linux

don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3` try-build: i686-mingw

…jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3` try-build: i686-mingw

Rollup merge of rust-lang#133633 - jyn514:hide-linker-args, r=bjorn3,jyn514 don't show the full linker args unless `--verbose` is passed the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them. split out from rust-lang#119286. fixes rust-lang#109979. r? `@bjorn3` try-build: i686-mingw

jyn514 · 2024-12-19T00:23:05Z

@bjorn3 this is ready for review :)

bjorn3

Apart from some concern about serialization of Span without serializing the corresponding source map, this LGTM.

bjorn3 · 2024-12-19T10:16:54Z

compiler/rustc_middle/src/lint.rs

@@ -173,7 +173,7 @@ impl TyCtxt<'_> {
 /// This struct represents a lint expectation and holds all required information
 /// to emit the `unfulfilled_lint_expectations` lint if it is unfulfilled after
 /// the `LateLintPass` has completed.
-#[derive(Clone, Debug, HashStable)]
+#[derive(Clone, Debug, Encodable, Decodable, HashStable)]
 pub struct LintExpectation {


CodegenResults::serialize_rlink doesn't serialize the source map. While it this is fully correct and shouldn't be changed, this means that when a LintExpectation inside CodegenResults gets deserialized in a new compiler session, the Span inside of it will be garbage and similarly for the Span in LintLevelSource. Would it be possible to avoid serializing the spans? Or if not, replace them with DUMMY_SP? I'm not sure how well the linting infrastructure handles garbage spans.

I'm not sure how well the linting infrastructure handles garbage spans.

Probably doesn't handle garbage spans. If the spans are empty or hi < lo, I think that triggers debug assertions.

The raw lo and hi values are preserved across the serialization roundtrip (so the lo <= hi invariant is preserved (empty spans are valid and rendered as a span from lo to lo + 1)), however they refer to non-existent parts of the source map.

Hm, if those become OOB, then I think they also trigger debug assertions (or actual assertions) if there's any lint that unwraps when trying to read a SourceMap snippet.

this indeed crashes currently:

=== STDERR === thread 'rustc' panicked at compiler/rustc_span/src/source_map.rs:1056:40: index out of bounds: the len is 0 but the index is 18446744073709551615

i thought i could solve this by deserializing to a dummy span but that doesn't seem to have worked for some reason? it still gives the same error.

INFO rustc_codegen_ssa::back::link Deny Node { name: "linker_messages", span: no-location (#0), reason: None }

i think the right fix here is not to use a source span map at all during -Z link-only, to have the emitter return None in Emitter::source_map. but i am not sure exactly how to set that up.

bors · 2024-12-20T23:50:06Z

☔ The latest upstream changes (presumably #134582) made this pull request unmergeable. Please resolve the merge conflicts.

this was slightly complicated because codegen_ssa doesn't have access to a tcx.

note that this still ICEs when passed `-Z link-only --error-format json` because i can't be bothered to fix it right now

bjorn3 · 2025-01-04T19:36:23Z

compiler/rustc_passes/messages.ftl

@@ -804,6 +804,9 @@ passes_unused_duplicate =
 passes_unused_empty_lints_note =
    attribute `{$name}` with an empty list has no effect

+passes_unused_linker_warnings_note =
+    the `linker_warnings` lint can only be controlled at the root of a crate with `--crate-type bin`


It is also allowed at the root of dylib, cdylib and proc-macro crates. Maybe say that it can only be controlled at the root of a crate that needs to be linked. Or just always allow it. If you define a crate as both rlib and dylib in Cargo.toml and compile for a target that doesn't support dylibs, cargo will drop the dylib crate type. This probably shouldn't cause a warning that #[allow(linker_messages)] is not allowed.

bjorn3 · 2025-01-04T19:38:16Z

tests/run-make/linker-warning/rmake.rs

+        // probably good enough.
+        .assert_stderr_contains("linker stderr: bar");
+
+    // Same thing, but with json output. This currently isn't supported and just ICEs.


Can you at least add a FIXME at the location where this ICEs?

Actually, this will have to be fixed before the PR can land as cargo always uses the json output format and thus would cause an ICE on any linker warning.

rustbot assigned bjorn3 Dec 24, 2023

jyn514 force-pushed the linker-output branch 2 times, most recently from 060a457 to a34d7ae Compare December 24, 2023 23:47

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch 2 times, most recently from 64cb47a to ab6fb2b Compare December 25, 2023 00:55

jyn514 mentioned this pull request Dec 25, 2023

Unreadable error messages on linking failure #46998

Open

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch from ab6fb2b to ba4425d Compare December 25, 2023 01:40

Noratrieb reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_interface/src/tests.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_session/src/options.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Show resolved Hide resolved

jyn514 force-pushed the linker-output branch from ba4425d to 43edbe0 Compare December 25, 2023 11:42

jyn514 force-pushed the linker-output branch from 43edbe0 to cbf71f7 Compare January 19, 2024 23:33

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch from cbf71f7 to 748af4f Compare January 20, 2024 01:05

jyn514 mentioned this pull request Jan 20, 2024

Track verbose and verbose_internals #120159

Merged

jyn514 force-pushed the linker-output branch from 748af4f to aac51d5 Compare January 20, 2024 13:04

jyn514 force-pushed the linker-output branch from 5513fb7 to b3b0202 Compare December 1, 2024 19:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 1, 2024

ChrisDenton mentioned this pull request Dec 10, 2024

Cargo shouldn't set /WX (-Werror for MSVC linker) outside of CI rust-lang/cargo#13620

Open

jyn514 force-pushed the linker-output branch from b3b0202 to f89d8db Compare December 18, 2024 23:01

bjorn3 approved these changes Dec 19, 2024

View reviewed changes

jyn514 added 5 commits December 21, 2024 10:09

show linker warnings even if it returns 0

457de8c

make it possible to silence linker warnings with a crate-level attribute

a1e8c05

this was slightly complicated because codegen_ssa doesn't have access to a tcx.

warn on unused linker_messages warning attributes

de9ca87

ignore linker errors on all platforms

b8edb37

don't ICE when emitting linker errors during -Z link-only

6baa8e6

note that this still ICEs when passed `-Z link-only --error-format json` because i can't be bothered to fix it right now

jyn514 force-pushed the linker-output branch from d018f4d to 6baa8e6 Compare December 21, 2024 15:12

bjorn3 reviewed Jan 4, 2025

View reviewed changes

Noratrieb added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 4, 2025

rustbot mentioned this pull request Jan 4, 2025

Tracking issue for release notes of #119286: show linker output even if the linker succeeds #135106

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show linker output even if the linker succeeds #119286

show linker output even if the linker succeeds #119286

jyn514 commented Dec 24, 2023 •

edited

Loading

rustbot commented Dec 24, 2023

jyn514 commented Dec 24, 2023

This comment has been minimized.

jyn514 commented Dec 25, 2023

This comment has been minimized.

bors commented Jan 6, 2024

This comment has been minimized.

jyn514 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

jyn514 commented Dec 1, 2024

bors commented Dec 9, 2024

jyn514 commented Dec 19, 2024

bjorn3 left a comment

bjorn3 Dec 19, 2024

jieyouxu Dec 19, 2024 •

edited

Loading

bjorn3 Dec 19, 2024

jieyouxu Dec 19, 2024

jyn514 Dec 21, 2024

bors commented Dec 20, 2024

bjorn3 Jan 4, 2025

bjorn3 Jan 4, 2025

bjorn3 Jan 5, 2025

show linker output even if the linker succeeds #119286

Are you sure you want to change the base?

show linker output even if the linker succeeds #119286

Conversation

jyn514 commented Dec 24, 2023 • edited Loading

rustbot commented Dec 24, 2023

jyn514 commented Dec 24, 2023

This comment has been minimized.

jyn514 commented Dec 25, 2023

This comment has been minimized.

bors commented Jan 6, 2024

This comment has been minimized.

jyn514 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

jyn514 commented Dec 1, 2024

bors commented Dec 9, 2024

jyn514 commented Dec 19, 2024

bjorn3 left a comment

Choose a reason for hiding this comment

bjorn3 Dec 19, 2024

Choose a reason for hiding this comment

jieyouxu Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

bjorn3 Dec 19, 2024

Choose a reason for hiding this comment

jieyouxu Dec 19, 2024

Choose a reason for hiding this comment

jyn514 Dec 21, 2024

Choose a reason for hiding this comment

bors commented Dec 20, 2024

bjorn3 Jan 4, 2025

Choose a reason for hiding this comment

bjorn3 Jan 4, 2025

Choose a reason for hiding this comment

bjorn3 Jan 5, 2025

Choose a reason for hiding this comment

jyn514 commented Dec 24, 2023 •

edited

Loading

jieyouxu Dec 19, 2024 •

edited

Loading