Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0389 needs to be updated to new format #35630

Closed
sophiajt opened this issue Aug 12, 2016 · 3 comments
Closed

E0389 needs to be updated to new format #35630

sophiajt opened this issue Aug 12, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 12, 2016

From: src/test/compile-fail/E0389.rs

E0389 needs a span_label, taking it from:

error[E0389]: cannot assign to data in a `&` reference
  --> src/test/compile-fail/E0389.rs:18:5
   |
18 |     fancy_ref.num = 6; //~ ERROR E0389
   |     ^^^^^^^^^^^^^^^^^

To:

error[E0389]: cannot assign to data in a `&` reference
  --> src/test/compile-fail/E0389.rs:18:5
   |
18 |     fancy_ref.num = 6; //~ ERROR E0389
   |     ^^^^^^^^^^^^^^^^^ assignment into an immutable reference
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 13, 2016
@sophiajt sophiajt reopened this Aug 13, 2016
@sophiajt sophiajt changed the title E0388 needs to be updated to new format E0389 needs to be updated to new format Aug 13, 2016
@ahmedcharles
Copy link
Contributor

src/test/compile-fail/E0389.rs doesn't exist and I can't seem to write a test file that triggers this error.

@sophiajt
Copy link
Contributor Author

Have you done a 'git pull' recently? Iirc, it's one of the test files that just landed.

@ahmedcharles
Copy link
Contributor

It's there now, so it must have landed recently. Thanks.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 26, 2016
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 27, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants