Skip to content

Commit

Permalink
Rollup merge of #130440 - compiler-errors:rpitit-opaque-hidden, r=jie…
Browse files Browse the repository at this point in the history
…youxu

Don't ICE in `opaque_hidden_inferred_bound` lint for RPITIT in trait with no default method body

Inline comment should explain the fix.

Fixes #130422
  • Loading branch information
matthiaskrgr authored Sep 17, 2024
2 parents c896f06 + 6e982f5 commit 02b1776
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
12 changes: 12 additions & 0 deletions compiler/rustc_lint/src/opaque_hidden_inferred_bound.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,18 @@ impl<'tcx> LateLintPass<'tcx> for OpaqueHiddenInferredBound {
let hir::ItemKind::OpaqueTy(opaque) = &item.kind else {
return;
};

// If this is an RPITIT from a trait method with no body, then skip.
// That's because although we may have an opaque type on the function,
// it won't have a hidden type, so proving predicates about it is
// not really meaningful.
if let hir::OpaqueTyOrigin::FnReturn(method_def_id) = opaque.origin
&& let hir::Node::TraitItem(trait_item) = cx.tcx.hir_node_by_def_id(method_def_id)
&& !trait_item.defaultness.has_value()
{
return;
}

let def_id = item.owner_id.def_id.to_def_id();
let infcx = &cx.tcx.infer_ctxt().build();
// For every projection predicate in the opaque type's explicit bounds,
Expand Down
16 changes: 16 additions & 0 deletions tests/ui/impl-trait/opaque-hidden-inferred-rpitit.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//@ check-pass

// Make sure that the `opaque_hidden_inferred_bound` lint doesn't fire on
// RPITITs with no hidden type.

trait T0 {}

trait T1 {
type A: Send;
}

trait T2 {
fn foo() -> impl T1<A = ((), impl T0)>;
}

fn main() {}

0 comments on commit 02b1776

Please sign in to comment.