Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add the LoongArch stabilized target features #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jan 3, 2025

This PR adds the stabilized target features as part of rust-lang/rust#135015.

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jan 3, 2025
@heiher heiher force-pushed the loong-target-features branch from bc1984d to f07ba46 Compare January 3, 2025 07:05
@ehuss ehuss added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Jan 7, 2025
Comment on lines +243 to +244
[LoongArch Reference Manual]: https://github.com/loongson/LoongArch-Documentation
[LoongArch GitHub Account]: https://github.com/loongson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation that is more alive than these links? The documentation link looks like it is archived, and I don't know what else I would look at on the GitHub account. Is there a new location where the documentation lives? Is there a way to deep-link to the individual features (like wasm does)?

`frecipe` | | FRECIPE --- Reciprocal approximation instrutions
`lasx` | `lsx` | LASX --- 256-bit vector instructions
`lbt` | | LBT --- Binary translation instructions
`lsx` | `d` | LSX --- 128-bit vector instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mentions d as an implicitly enabled feature, but I don't see that as a feature that exists.

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: The marked PR is awaiting review from a maintainer labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants