Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax feature flag for value's std_support #657

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

tisonkun
Copy link
Contributor

This closes #654 (comment).

While I agree @KodrAus's comment at #654 (comment), this is not a generally breaking down kv_x to kv + x.

But that value's std_support can work with kv + std. kv_std introduces an extra feature of value-bag/error, which is only used for:

    pub fn to_borrowed_error(&self) -> Option<&(dyn std::error::Error + 'static)> {
        self.inner.to_borrowed_error()
    }

above.

@KodrAus
Copy link
Contributor

KodrAus commented Jan 10, 2025

Thanks @tisonkun. I think this specific change is reasonable to make 👍

@KodrAus KodrAus merged commit 0ce1442 into rust-lang:master Jan 10, 2025
14 checks passed
@tisonkun tisonkun deleted the relax-feature-flag branch January 10, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv_std should be broken down into kv + std?
2 participants