Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features page: mark all active by default features #2531

Closed
llogiq opened this issue Jun 23, 2024 · 1 comment
Closed

Features page: mark all active by default features #2531

llogiq opened this issue Jun 23, 2024 · 1 comment

Comments

@llogiq
Copy link
Contributor

llogiq commented Jun 23, 2024

Currently, the page shows the default feature, but there is no easy way to see which features are transitively active by default.

This would require going through the features list and activate all that are transitively reachable from default. Also probably steer clear from infinite runtime due to cycles by some sort of visited marker or cycle detection.

Swatinem added a commit to Swatinem/docs.rs that referenced this issue Jun 24, 2024
Fixes rust-lang#2531 by marking every (transitive) default feature with a `*`.
The features list is already sorted according to depth-first `"default"` order first, and according to the number of sub-features.

I changed that so the secondary sort order is alphabetic, as that might make more sense than sorting by number of sub-features.
@syphar
Copy link
Member

syphar commented Jul 31, 2024

resolved in #2532 too

@syphar syphar closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants