Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down some crate versions; update others semver compatibly #710

Merged
merged 3 commits into from
May 3, 2017

Conversation

carols10cents
Copy link
Member

In order to be able to build successfully without the lockfile, which
happens when verifying with cargo package since package never includes
Cargo.lock
.

If we don't constrain these crates' versions, they update to
incompatible versions of, most problematically, serde_json.

openssl has also deprecated the finish method and changed some types
in a minor version bump. I don't feel like figuring it out right now so I'm locking it down too :P

@carols10cents carols10cents requested a review from alexcrichton May 3, 2017 18:37
@alexcrichton
Copy link
Member

Hm I'm generally quite anti-=-dependencies, I'll look into fixing these.

@alexcrichton
Copy link
Member

I think this is the problem, Cargo doesn't know that it needs to use serde_json 0.9 there, so postgres-shared is getting serde_json 1.0 while we're getting serde_json 0.9, causing compile issues.

@alexcrichton
Copy link
Member

cc @sfackler (on previous comment), just to make sure you're aware, not sure you want to take any action though

@alexcrichton
Copy link
Member

Ok after #711 let's just solve it here. @carols10cents my theory makes me think that we can get by locking just postgres-shared, or basically finding a version of postgres that doesn't have the wider range of deps on serde. Did you find that locking openssl/serde/etc were required as well?

If not, could you back out the other locked versions here and just lock postgres-shared, and then place a comment above it as to why it's locked and when the lock can be removed? #711 should have an example of dealing with the OpenSSL change as well. You can also just #[allow(deprecation)]

@carols10cents carols10cents force-pushed the put-crates-on-lockdown branch from 2dc7dd0 to dfcdb98 Compare May 3, 2017 22:39
@carols10cents
Copy link
Member Author

@alexcrichton you're totally right, i just tried locking down the others first and that didn't work so I kept adding and didn't go back to remove.

@alexcrichton alexcrichton merged commit 73b3491 into rust-lang:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants