Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sparse git repo without erroring. #8775

Closed
wants to merge 1 commit into from

Conversation

chachi
Copy link

@chachi chachi commented Oct 13, 2020

Workaround for libgit2 spuriously erroring causing cargo to refuse to build.

Fixes #8746 and #7876

Upstream fix: libgit2/libgit2#5656

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2020
@ehuss
Copy link
Contributor

ehuss commented Oct 14, 2020

I'm not sure, but I don't think this is needed with #8778?

Also, I'm not sure if #7876 is actually fixed. The original report didn't include a working reproduction, so it is difficult to guess what the original reporter was running into.

@chachi
Copy link
Author

chachi commented Oct 14, 2020

Indeed. Looks like it works without this anymore. Excited that got fixed so quickly! Closing.

@chachi chachi closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build projects after updating to 1.46.0 when our repo is using sparse-checkouts
4 participants