Fix build scripts and panic=abort #2730
Conversation
Build scripts were apparently always compiled with the "dev" profile rather than the standard "match whatever the normal build was" profile, which meant that if dev/release disagreed on panic=abort you'd get compile errors. Seems bad! This commit fixes this by just having build scripts always compile with the same profile as libraries (for now), as this was the original intention anyway. Closes rust-lang#2726
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 183c59c has been approved by |
…excrichton Fix build scripts and panic=abort Build scripts were apparently always compiled with the "dev" profile rather than the standard "match whatever the normal build was" profile, which meant that if dev/release disagreed on panic=abort you'd get compile errors. Seems bad! This commit fixes this by just having build scripts always compile with the same profile as libraries (for now), as this was the original intention anyway. Closes #2726
|
💔 Test failed - cargo-mac-32 |
|
@bors: retry On Mon, May 23, 2016 at 2:03 PM, bors [email protected] wrote:
|
|
⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-cross-linux, cargo-mac-32... |
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Build scripts were apparently always compiled with the "dev" profile rather than
the standard "match whatever the normal build was" profile, which meant that if
dev/release disagreed on panic=abort you'd get compile errors. Seems bad!
This commit fixes this by just having build scripts always compile with the same
profile as libraries (for now), as this was the original intention anyway.
Closes #2726