Convert chapters 15 #3956
Merged
Convert chapters 15 #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Note that there are real CI failures due to some missed opening/closing tags, etc., so once you address that, I'll be happy to review it and get it landed! |
|
The opening/closing tags is a bad error, I've found. This is the result of the |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Ah, that makes sense (per your comment on the tracking issue) @bzierk – thanks! |
chriskrycho
added a commit
that referenced
this pull request
Oct 15, 2024
This restores the work originally done in #3956, which had to be dropped from that PR because this chapter was blocked on XML handling, which was resolved in #3975. Co-authored-by: Bryan Zierk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Listing conversion for chapter 12, 13, 14, and 15