WIP: miniscript: Import update_psbt_input from plan module #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we cannot use the miniscript module without bringing in the `Plan::update_psbt_input` function because it takes an `Input` as parameter. Just do a quick and dirty import changing `self` to be `plan: &Plan`.
This was referenced Sep 20, 2024
|
Not doing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this accesses private fields on the
Plantype. I made them public in a local version ofminiscriptand patched the manifest and tested withbdk.Turns out we cannot use the miniscript module without bringing in the
Plan::update_psbt_inputfunction because it takes anInputas parameter.Just do a quick and dirty import changing
selfto beplan: &Plan.