Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orchestrator options #29

Closed
wants to merge 1 commit into from

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Jul 9, 2019

This is a work in progress, to address:

feedback from @ProTip

For orchestrator config I'm a little concerned that the Terraform schema may stray from the API schema in a way that reduces the flexibility. Unlike notification which has "built in" notifications, email and webhook_urls, separate from a "plugin" config the orchestrator block is itself a "plugin" config. So its schema is pretty much the same as for the notification plugin block: https://github.com/terraform-providers/terraform-provider-rundeck/blob/master/rundeck/resource_job.go#L310-L323 .

The builtin orchestrator plugins happen to have one configuration key, however others could in theory have arbitrary configuration elements. It would reduce or make "validation" more tricky, but I'm wondering if it would be better to model the orchestrator schema after the notification plugin block?

@tebriel
Copy link
Contributor Author

tebriel commented Jul 9, 2019

Okay, that's a good point, I'll make it mirror that config map to avoid future compatibility issues.

@fardin01
Copy link

Hi @tebriel. Just wondering if you ever had the time to get back to this? This would be a very cool feature to have. Let me know if there is anything I can do (bear in mind I have limited Goland skills). Thanks :)

@tebriel
Copy link
Contributor Author

tebriel commented Jun 23, 2020

@fardin01 sorry, but I've left the Pindrop company and no longer have an environment where I manage rundeck. I wish you the best of luck if you want to pick this up!

@fdevans
Copy link
Contributor

fdevans commented Oct 9, 2023

Closing. See #107

@fdevans fdevans closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants