-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed "rust" as a keyword in the .desktop #19093
Conversation
I'll assume you're having this problem with the flatpack release |
No in fact, I'm already building Ruffle from source using cargo... |
Hi @RubisetCie and thank you for your contribution! I think you are making a great point—keywords are about searching, and we should ask the question whether the user wants to see Ruffle when they are searching for "rust". I believe it's a good idea to rethink keywords in general, as modifying each keyword means we have to redo all of the translations (we'd modify them only in |
that's odd. I was only ever able to replicate your problem with the start menu after installing the flatpack version, as I compile ruffle myself often and don't encounter this issue. |
I don't think that's particularly helpful, as you give up major features that way, which are important to some people (automatic updates, easy management, sandboxing). Not mentioning the fact that we should strive to improve the experience of using Ruffle. |
you make regular ruffle sound crippled or unsafe, which I don't agree to be the case |
Just to make sure @RubisetCie, the issue is fixed after applying changes from this PR? How do you install Ruffle after building? |
@kjarosh Yes, just removing "rust" in the keyword list is enough to make everything perfect to me. :) @Croworbit I think there may be a misunderstanding, I'm mainly talking from a "semantic" point of view; when the users are typing "rust" in the start menu, I think they should find developer tools (like RustRover for example), but not applications developped in Rust... don't you agree? |
yes, I do agree |
Keywords are used for searching and Ruffle shouldn't be a result when searching for "rust", as users usually expect e.g. tools and IDEs related to programming in Rust.
ed9645b
to
134ccc4
Compare
Thank you! |
First of all, I know how this might looks, and I don't wish to sound "insulting" or petty. :)
I know you're all proud rustaceans, and you should be, because Rust is a great programming language. Be proud of your project, Ruffle is amazing! :D
But... was it necessary to put "rust" as a keyword in the .desktop file? To me the end user shouldn't care about what programming language was used to develop Ruffle... besides, it is already mentionned in the package description and it messes up my start menu when I type "rust"...
However don't worry, I wouldn't mind much if you choose to reject my PR. Have a great day.