Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "rust" as a keyword in the .desktop #19093

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

RubisetCie
Copy link
Contributor

First of all, I know how this might looks, and I don't wish to sound "insulting" or petty. :)
I know you're all proud rustaceans, and you should be, because Rust is a great programming language. Be proud of your project, Ruffle is amazing! :D

But... was it necessary to put "rust" as a keyword in the .desktop file? To me the end user shouldn't care about what programming language was used to develop Ruffle... besides, it is already mentionned in the package description and it messes up my start menu when I type "rust"...

However don't worry, I wouldn't mind much if you choose to reject my PR. Have a great day.

@Croworbit
Copy link

I'll assume you're having this problem with the flatpack release
have you tried downloading the standalone versions, or compiling from source?
Ruffle doesn't necessarily need to be installed, and that should avoid this issue

@RubisetCie
Copy link
Contributor Author

No in fact, I'm already building Ruffle from source using cargo...

@kjarosh
Copy link
Member

kjarosh commented Dec 30, 2024

Hi @RubisetCie and thank you for your contribution! I think you are making a great point—keywords are about searching, and we should ask the question whether the user wants to see Ruffle when they are searching for "rust".

I believe it's a good idea to rethink keywords in general, as modifying each keyword means we have to redo all of the translations (we'd modify them only in *.in files, as the rest is generated).

@Croworbit
Copy link

that's odd. I was only ever able to replicate your problem with the start menu after installing the flatpack version, as I compile ruffle myself often and don't encounter this issue.

@kjarosh
Copy link
Member

kjarosh commented Dec 30, 2024

have you tried downloading the standalone versions, or compiling from source?
Ruffle doesn't necessarily need to be installed, and that should avoid this issue

I don't think that's particularly helpful, as you give up major features that way, which are important to some people (automatic updates, easy management, sandboxing).

Not mentioning the fact that we should strive to improve the experience of using Ruffle.

@Croworbit
Copy link

Croworbit commented Dec 30, 2024

you make regular ruffle sound crippled or unsafe, which I don't agree to be the case
(the keyword removal is a good idea)

@kjarosh
Copy link
Member

kjarosh commented Dec 30, 2024

Just to make sure @RubisetCie, the issue is fixed after applying changes from this PR? How do you install Ruffle after building?

@RubisetCie
Copy link
Contributor Author

@kjarosh Yes, just removing "rust" in the keyword list is enough to make everything perfect to me. :)

@Croworbit I think there may be a misunderstanding, I'm mainly talking from a "semantic" point of view; when the users are typing "rust" in the start menu, I think they should find developer tools (like RustRover for example), but not applications developped in Rust... don't you agree?

@Croworbit
Copy link

@Croworbit I think there may be a misunderstanding, I'm mainly talking from a "semantic" point of view; when the users are typing "rust" in the start menu, I think they should find developer tools (like RustRover for example), but not applications developped in Rust... don't you agree?

yes, I do agree
that's wh\y I said what I said in parenthesis in my earlier comment

@danielhjacobs danielhjacobs added A-desktop Area: Desktop Application T-refactor Type: Refactor / Cleanup labels Jan 2, 2025
Keywords are used for searching and Ruffle shouldn't be a result when
searching for "rust", as users usually expect e.g. tools and IDEs
related to programming in Rust.
@kjarosh kjarosh force-pushed the altered-desktop-keywords branch from ed9645b to 134ccc4 Compare January 3, 2025 21:07
@kjarosh kjarosh enabled auto-merge (rebase) January 3, 2025 21:08
@kjarosh kjarosh merged commit 75dba08 into ruffle-rs:master Jan 3, 2025
22 checks passed
@kjarosh
Copy link
Member

kjarosh commented Jan 4, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application T-refactor Type: Refactor / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants